Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Bring tile queryPadding behavior back into conformance with GL JS #12701

Closed
ChrisLoer opened this issue Aug 21, 2018 · 2 comments
Closed

Bring tile queryPadding behavior back into conformance with GL JS #12701

ChrisLoer opened this issue Aug 21, 2018 · 2 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS querying Issues with querySourceFeatures or queryRenderedFeatures

Comments

@ChrisLoer
Copy link
Contributor

GL JS made a change to how it calculates queryPadding in mapbox/mapbox-gl-js#6909.

I'm not sure if the change is relevant to gl-native, but it changes the behavior of the "multiple-layers" query tests.

cc @ryanhamley
@ryanhamley
Copy link
Contributor

mapbox/mapbox-gl-js#6896 is the original ticket that mapbox/mapbox-gl-js#6909 fixed. In GL JS, queryPadding was being calculated based on the first layer in a bucket because the code was hardcoded to always take the first element from bucket.layerIds. I changed it to be calculated for each layer and added a few different query tests to verify the new behavior.

@kkaefer kkaefer added GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl querying Issues with querySourceFeatures or queryRenderedFeatures and removed querying Issues with querySourceFeatures or queryRenderedFeatures labels Sep 25, 2018
@stale stale bot added the archived Archived because of inactivity label Mar 24, 2019
@stale
Copy link

stale bot commented Mar 26, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS querying Issues with querySourceFeatures or queryRenderedFeatures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kkaefer @ChrisLoer @ryanhamley