Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Respect user default (NSUserDefaults) for MGLCollisionBehaviorPre4_0 Info.plist key #13155

Closed
samfader opened this issue Oct 22, 2018 · 2 comments
Assignees
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Comments

@samfader
Copy link
Contributor

samfader commented Oct 22, 2018

This is more of a feature request so I've changed the template around:

The request

With the MGLCollisionBehaviorPre4_0 Info.plist key added here (#12941), app developers can now set this key to determine cross-source collision behavior. However, there is no way to set this key at the developer level (NSUserDefaults).

I know there is some discussion as to why this choice was made here, but it would be useful to those wrapping the iOS SDK to have a user-controlled option here as well.

@samfader samfader added the iOS Mapbox Maps SDK for iOS label Oct 22, 2018
@1ec5
Copy link
Contributor

1ec5 commented Oct 23, 2018

However, there is no way to set this key at the user level (NSUserDefaults).

NSUserDefaults is something of a misnomer. The only practical difference between Info.plist keys and NSUserDefaults settings is that the latter can be set at runtime, whereas the former is static – it can only be set at build time and can’t differ from device to device. With the Info.plist key, a wrapper of this SDK would have no control over the setting.

@1ec5
Copy link
Contributor

1ec5 commented Dec 18, 2018

Fixed in #13426.

@1ec5 1ec5 closed this as completed Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

5 participants