Missing outlet warning at launch in macosapp

[1ec5]

The following warning appears in the console when launching macosapp as of 8389e74:

2019-04-10 13:41:56.090895-0700 Mapbox GL[30223:7451050] Failed to connect (includeIdeographsBox) outlet from (MapDocument) to (NSButton): missing setter or instance variable

/cc @fabian-guerra

[1ec5]

The “Include CJK characters” checkbox in the Add Offline Pack sheet is hooked up to MapDocument.includeIdeographsBox, which isn’t defined.

#13607 added this checkbox to the sheet but defined the outlet as includesIdeographicGlyphsBox:

mapbox-gl-native/platform/macos/app/MapDocument.m

Line 85 in d3bb518

@property (weak) IBOutlet NSButton *includesIdeographicGlyphsBox;

It was probably a last-minute refactoring, but it means that the checkbox has been nonfunctional all this time. Any offline pack size estimates that depended on this checkbox being unchecked are inaccurate.

/cc @chloekraw @coxchapman

[chloekraw]

Thanks for catching this and fixing it so quickly @1ec5! Is this the kind of thing we can or should add tests for?

cc/ @mapbox/maps-ios

[1ec5]

This only surfaced as a runtime warning, since it was an application-level UI bug. We’d need to create an UI test integration target like we have for iOS. It’d be a bit of a big lift, versus educating contributors to this codebase that XIBs can have code-level dependencies on source files.