Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

AnnotationManager::getAnnotationsInBounds broken #1660

Closed
incanus opened this issue May 28, 2015 · 4 comments
Closed

AnnotationManager::getAnnotationsInBounds broken #1660

incanus opened this issue May 28, 2015 · 4 comments
Assignees
@incanus
Labels
bug
Milestone
iOS Beta 2

Comments

@incanus
Copy link
Contributor

incanus commented May 28, 2015

Noticed while working in #1655 — applies to current master as well. Always comes up empty.
@incanus incanus added the bug label May 28, 2015
@incanus incanus added this to the iOS Beta 2 milestone May 28, 2015
@1ec5
Copy link
Contributor

1ec5 commented May 28, 2015

Reproduces until you zoom in or out.

@incanus incanus self-assigned this Jun 1, 2015
@incanus
Copy link
Contributor Author

incanus commented Jun 1, 2015

Not sure what conditions you were seeing this under @1ec5, but my case was due to not clamping latitude for Mercator (bf6be3c) and another issue around returning duplicate annotations for the query (8626f91).

@incanus incanus mentioned this issue Jun 1, 2015
Closed
@incanus
Copy link
Contributor Author

incanus commented Jun 1, 2015

This is all patched up now. 376ad5e fixes things for shapes (union, not containment) and da01318 allows filtering by annotation type in the C++ API, which iOS now uses to filter to just points for tap selection.

@incanus incanus closed this as completed Jun 1, 2015
@incanus incanus removed the ready label Jun 1, 2015
@1ec5
Copy link
Contributor

1ec5 commented Jun 2, 2015

I was seeing #1675 rather than this bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@incanus incanus

Labels
bug
Projects
None yet
Milestone
iOS Beta 2
Development

No branches or pull requests
3 participants
@incanus @jfirebaugh @1ec5