Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Make MapView's setStyleJson public #1997

Closed
erf opened this issue Aug 5, 2015 · 5 comments
Closed

Make MapView's setStyleJson public #1997

erf opened this issue Aug 5, 2015 · 5 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@erf
Copy link
Contributor

erf commented Aug 5, 2015

I would like to have setStyleJson as a public method in MapView, like so:

    public void setStyleJson(String json){
        mNativeMapView.setStyleJson(json);
    }
@1ec5 1ec5 added the Android Mapbox Maps SDK for Android label Aug 5, 2015
@1ec5
Copy link
Contributor

1ec5 commented Aug 5, 2015

For reference, on the iOS side, we removed -setStyleJSON: in #1299 but are definitely open to reintroducing granular styling in some form (#837).

@ljbade
Copy link
Contributor

ljbade commented Aug 6, 2015

I'd much rather see #837 as the public API instead of this as setting the JSON directly is messy and I recall it causing issues a while ago.

@jfirebaugh Should we expose this to developers?

@jfirebaugh
Copy link
Contributor

Yep, #837 covers what our plans are for public APIs in this area. @erf, let us know if for some reason your use case wouldn't be satisfied with that approach.

@erf
Copy link
Contributor Author

erf commented Aug 6, 2015

@jfirebaugh #837 looks promising - has work on this begun for Android ?

@jfirebaugh
Copy link
Contributor

No, we haven't started on it for any native platform yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants