Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Get tests to work on iOS/Android #2150

Closed
kkaefer opened this issue Aug 21, 2015 · 13 comments
Closed

Get tests to work on iOS/Android #2150

kkaefer opened this issue Aug 21, 2015 · 13 comments
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity iOS Mapbox Maps SDK for iOS tests

Comments

@kkaefer
Copy link
Member

kkaefer commented Aug 21, 2015

We should run all available test suites on each platform.

Platform Core tests Rendering tests Platform tests
Android #4671 #2488 ✔︎
iOS ✔︎ (Regressed) #2488 #4495, #2734, etc.
OS X ✔︎ #2488 ✔︎
Linux ✔︎ #2488 n/a
Node OS X n/a ✔︎ ✔︎
Node Linux n/a ✔︎ ✔︎
@kkaefer kkaefer added the tests label Aug 21, 2015
@ljbade ljbade added iOS Mapbox Maps SDK for iOS Android Mapbox Maps SDK for Android labels Aug 25, 2015
@ljbade
Copy link
Contributor

ljbade commented Aug 25, 2015

On Android side there have been a few tickets in this area: #1667

@ljbade
Copy link
Contributor

ljbade commented Sep 7, 2015

And #1898

@tobrun
Copy link
Member

tobrun commented Jan 11, 2016

Closing this down because we have UI testing frameworks for both platforms:

  • Espresso on Android
  • KIF on iOS

@tobrun tobrun closed this as completed Jan 11, 2016
@jfirebaugh
Copy link
Contributor

Technically this is still relevant: in a perfect world we would run the headless rendering tests on every platform. It's low priority / not actionable right now though.

@tobrun
Copy link
Member

tobrun commented Jan 11, 2016

@jfirebaugh on Android we have Unit tests using JUnit, these are executed on each commit to this repo.
Coverage is not that high but we are working on this to improve.

@1ec5 / @friedbunny does iOS have this?

@friedbunny
Copy link
Contributor

iOS only has functionality tests, using KIF.

@kkaefer
Copy link
Member Author

kkaefer commented Jan 12, 2016

@tobrun KIF/JUnit are running integration tests. This issue is about unit tests, that independently test parts of the system. Integration tests may not cover everything tested by unit tests (and vice versa).

@kkaefer kkaefer reopened this Jan 12, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jan 12, 2016

As of #3406, a little of the code shared between the iOS and OS X SDKs is being unit tested (in the strict sense of the word) on OS X. However, this issue sounds like it’s about the rendering and mbgl tests, which currently rely on gtest. Is gtest compatibility with iOS even feasible?

@tmpsantos
Copy link
Contributor

Running at least the test/storage tests would be extremely recommended and should be the priority, as these will test the platform specific network backend.

There are several corner cases that must be handled by the network backend that if not implemented correctly can interfere with the cache operation, rendering of stale tiles, etc. They are all covered by the tests.

/cc @tobrun

@jfirebaugh
Copy link
Contributor

I started trying to do this in android-tests. It's difficult because the tests are currently a monolithic thing which requires a full headless implementation for whatever platform they're running on. We may need to split them (and the mbgl-core library they link against) into a part that relies on GL and a part with minimal dependencies.

@jfirebaugh
Copy link
Contributor

In #3989 we have a test scheme for the iOS Xcode project which runs most (but not all) of the core unit tests. Getting it to actually run successfully in a CI environment is challenging however, and hasn't been tackled yet.

@jfirebaugh
Copy link
Contributor

As of #4560 we run rendering tests on the OS X Bitrise Node build.

@stale
Copy link

stale bot commented Nov 23, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

No branches or pull requests

7 participants