Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

update GeoJSON VT version #2226

Closed
incanus opened this issue Sep 1, 2015 · 2 comments · Fixed by #2584
Closed

update GeoJSON VT version #2226

incanus opened this issue Sep 1, 2015 · 2 comments · Fixed by #2584
Labels
performance Speed, stability, CPU usage, memory usage, or power usage refactor
Milestone
ios-v3.0.0

Comments

@incanus
Copy link
Contributor

incanus commented Sep 1, 2015

We should wait until after the next ios-v2.1.0 release for this, but per 244fe93#commitcomment-13003393, we have a ton of work by @kkaefer on the C++ GeoJSON VT port in mapbox/geojson-vt-cpp@995ffc7...master that has never made its way into production code here in GL, nor back to the JS port source.

/cc @mourner
@incanus incanus added performance Speed, stability, CPU usage, memory usage, or power usage refactor labels Sep 1, 2015
incanus referenced this issue Sep 1, 2015
@tmpsantos
Bump geojsonvt version
244fe93 
It was downgraded (probably accidentally) by 60e9712.
@incanus incanus mentioned this issue Sep 2, 2015
Closed
4 tasks
@incanus incanus mentioned this issue Sep 24, 2015
Closed
6 tasks
@lucaswoj lucaswoj mentioned this issue Oct 1, 2015
Merged
@incanus
Copy link
Contributor Author

incanus commented Oct 16, 2015

We should hit this now as we are still running a GeoJSON VT in master that has nine commits instead of master's 62.

@kkaefer @jfirebaugh @mikemorris

@incanus incanus added this to the ios-v2.2.0 milestone Oct 16, 2015
@mikemorris mikemorris mentioned this issue Oct 16, 2015
Merged
4 tasks
@mikemorris
Copy link
Contributor

Working on this in #2584, but completely stumped dealing with mason-installed RapidJSON linker warnings in the iOS test suite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance Speed, stability, CPU usage, memory usage, or power usage refactor
Projects
None yet
Milestone
ios-v3.0.0
Development

Successfully merging a pull request may close this issue.

Install GeoJSONVT 2.1.6 from mason mapbox/mapbox-gl-native
2 participants
@incanus @mikemorris