Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Encapsulate Marker position and sprite #2551

Closed
bleege opened this issue Oct 7, 2015 · 3 comments
Closed

Encapsulate Marker position and sprite #2551

bleege opened this issue Oct 7, 2015 · 3 comments
Labels
Android Mapbox Maps SDK for Android
Milestone
android-v2.1.0

Comments

@bleege
Copy link
Contributor

bleege commented Oct 7, 2015

As #2535 showed us bad things can happen when field level access to Java objects is allowed. Let's double back and tighten this up. In order to do this we're going to have to first refactor the JNI bindings as described.

Going forward let's all @mapbox/mobile try to use the stock Java get/set encapsulation construct when possible. It'll help with automated testing when that rolls around as well as make life a little less dangerous.
@bleege bleege added the Android Mapbox Maps SDK for Android label Oct 7, 2015
@bleege bleege added this to the android-v2.2.0 milestone Oct 7, 2015
@ljbade
Copy link
Contributor

ljbade commented Oct 8, 2015

@bleege I'll hit moving the other ...Options classes to use get/set in the PR for #2546. Will keep an eye out for other JNI gremlins too.

This was referenced Oct 8, 2015
Closed
Merged
@ljbade
Copy link
Contributor

ljbade commented Oct 13, 2015

Landed in #2592

@ljbade ljbade closed this as completed Oct 13, 2015
@bleege bleege modified the milestones: android-v2.1.0, android-v2.2.0 Oct 13, 2015
@bleege
Copy link
Contributor Author

bleege commented Oct 13, 2015

Updated to android-v2.1.0 as this was done early.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v2.1.0
Development

No branches or pull requests
2 participants
@bleege @ljbade