Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Location setting disabled + last known location #2564

Closed
tobrun opened this issue Oct 8, 2015 · 10 comments
Closed

Location setting disabled + last known location #2564

tobrun opened this issue Oct 8, 2015 · 10 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@tobrun
Copy link
Member

tobrun commented Oct 8, 2015

When location setting is disabled and we press the FAB to enable user location, nothing happens.

Google maps shows a dialog to enable these settings:

device-2015-10-08-132500

If you select No, it uses a fallback location known as the last known location from google play services. This api is mirrored in LOST and we should add similar behaviour.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Oct 8, 2015
@ljbade
Copy link
Contributor

ljbade commented Oct 8, 2015

@tobrun I opened a ticket over in lostzen/lost#35

@tobrun
Copy link
Member Author

tobrun commented Oct 9, 2015

👍
@ljbade is their already a ticket for this in our issue tracker?

@ljbade
Copy link
Contributor

ljbade commented Oct 9, 2015

Not here, I think this first came up in Sirius, but let's leave this open for tracking.

@tobrun tobrun added this to the android-v2.2.0 milestone Oct 24, 2015
@bleege bleege modified the milestones: android-v2.2.0, android-v2.3.0 Oct 28, 2015
@bleege bleege modified the milestones: android-v2.3.0, android-v2.4.0 Dec 4, 2015
@bleege bleege modified the milestones: android-v3.0.0, android-v3.1.0 Dec 21, 2015
@tobrun
Copy link
Member Author

tobrun commented Jan 11, 2016

I reached out to Mapzen to ask them about ETA for this dialog

@bleege bleege modified the milestones: android-v3.1.0, android-v4.0.0 Jan 20, 2016
@tobrun
Copy link
Member Author

tobrun commented Feb 17, 2016

@bleege @zugaldia, I reached out to them and they would love to add this if we PR it. Is this something we want to do at this time? postpone after 4.0.0?

@bleege
Copy link
Contributor

bleege commented Feb 17, 2016

@tobrun This would be ideal to have in the Mapbox Android SDK. Can this be done in the SDK or does it need to be done in LOST?

@tobrun
Copy link
Member Author

tobrun commented Feb 18, 2016

@bleege, the reasons why I asked LOST was because it's currently integrated in Google Play Services.
We can definitely make this happen from within our SDK! 🚀

@bleege
Copy link
Contributor

bleege commented Feb 18, 2016

@tobrun Cool. We should definitely look to collaborate with LOST, but for the sake of timing it seemed more appropriate to build this in the Mapbox Android SDK first and then send it to LOST.

@zugaldia
Copy link
Member

zugaldia commented Feb 3, 2017

Just noting this landed on LOST 2.0 with lostzen/lost#64 and lostzen/lost#65.

@tobrun
Copy link
Member Author

tobrun commented Oct 10, 2017

We have deprecated LocationView with #9771, closing.

@tobrun tobrun closed this as completed Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

5 participants