Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use stale TileJSON data #2724

Closed
kkaefer opened this issue Oct 22, 2015 · 1 comment
Closed

Use stale TileJSON data #2724

kkaefer opened this issue Oct 22, 2015 · 1 comment
Labels
performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Oct 22, 2015

With #2617 in place, we now get stale data from the cache. Currently, stale TileJSON data loaded as part of loading a Source aren't used, but we should change this.

  • The easy case is when the refreshed request returns a 304. In this case, we don't have to do anything.
  • The hard case is when we get a different response. This is not a typical case however, so we could implement this with drastic action.

Things that could change in a TileJSON:

  • Tile endpoint: We need to reload all tiles to make sure we load the right data
  • Tile size: We need to recalculate the tiles we need to load because we might have to load tiles for a different zoom level
  • Min/Max zoom: We need to recalculate what tiles to load, if we have tiles loaded that are outside the new zoom range
  • Attribution: We need to notify the embedding application that this changed (Derive attribution from sources in current style #2723)
  • Center/bounds: We're not using these values currently
@kkaefer kkaefer added the performance Speed, stability, CPU usage, memory usage, or power usage label Oct 22, 2015
@kkaefer
Copy link
Contributor Author

kkaefer commented Jan 7, 2016

Implementation happens as part of #2721

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

1 participant