Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Can't inherit from final MapView class #3150

Closed
zugaldia opened this issue Nov 30, 2015 · 3 comments
Closed

Can't inherit from final MapView class #3150

zugaldia opened this issue Nov 30, 2015 · 3 comments
Labels
Android Mapbox Maps SDK for Android feature
Milestone
android-v3.1.0

Comments

@zugaldia
Copy link
Member

The MapView class is declared as final. This prevents the override of some useful methods like onSizeChanged() or setZoomLevel(). Unless there's a good technical reason not do so, we should make the class non-final.
@zugaldia zugaldia added feature Android Mapbox Maps SDK for Android labels Nov 30, 2015
@zugaldia
Copy link
Member Author

/cc: @tobrun

@bleege bleege modified the milestones: android-v2.3.0, android-v2.4.0 Nov 30, 2015
@tobrun
Copy link
Member

tobrun commented Dec 11, 2015

Yes I would like to see this happen, but we need to take into account how this will affect our refactor to a more loosely coupled architecture. Linking issue #3145 for that.

@bleege bleege modified the milestones: android-v3.0.0, android-v3.1.0 Dec 21, 2015
@tobrun
Copy link
Member

tobrun commented Jan 12, 2016

As mentioned above: this issue is not longer relevant due to refactor in #3145, closing.

@tobrun tobrun closed this as completed Jan 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android feature
Projects
None yet
Milestone
android-v3.1.0
Development

No branches or pull requests
3 participants
@zugaldia @bleege @tobrun