This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Avoid the blue background location status bar #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
bug
iOS
|
I looked into listening for |
|
This would disable telemetry collection even when the app itself is triggering the blue bar, right? |
|
Yup, we have no way of knowing if another location manager elsewhere in the app is still active. |
|
👍 |
Apps with `whenInUse` location permission will show a blue status bar when they continue to use location services after leaving the foreground. This is worrying and to be avoided, so let's disable telemetry location services in this situation. Fixes #2945
friedbunny
force-pushed
the
fb-telemetry-blue-bar-be-gone-2945
branch
from
77500e6
to
9418f9a
Compare
|
Rebased with an eye to merging. We'll revisit ways to better piggyback in the future, but for now let's err on the side of not being the sole cause of annoyance to users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps with
whenInUselocation permission will show a blue status bar when they continue to use location services after leaving the foreground. This is worrying and to be avoided, so let's disable telemetry location services in this situation.Fixes #2945, refs #3641.
/cc @boundsj @1ec5 @jfirebaugh @mikemorris