Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Allow C99 extensions in iOS and OS X SDK targets #4191

Closed
1ec5 opened this issue Mar 3, 2016 · 1 comment · Fixed by #4641
Closed

Allow C99 extensions in iOS and OS X SDK targets #4191

1ec5 opened this issue Mar 3, 2016 · 1 comment · Fixed by #4641
Assignees
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 3, 2016

C99 extensions are currently disallowed throughout the project due to pedantic warnings being enabled. This makes no sense in Objective-C code, since we’ve been able to depend on C99 support for years. At the least, the iOS and OS X SDK targets should get a -Wno-c99-extensions flag. This will enable us to remove a fair amount of redundant code in MGLMapView.

If any non-SDK Objective-C code needs to use C99-specific features like designated initializers or the Elvis operator, we can selectively turn off the Clang warning via #pragma clang diagnostic ignored "-Wc99-extensions" on a case-by-case basis.

/cc @jfirebaugh @boundsj

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build refactor macOS Mapbox Maps SDK for macOS labels Mar 3, 2016
@boundsj
Copy link
Contributor

boundsj commented Mar 3, 2016

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants