Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Avoid stripping debug symbols from -symbols builds #4379

Closed
1ec5 opened this issue Mar 18, 2016 · 1 comment
Closed

Avoid stripping debug symbols from -symbols builds #4379

1ec5 opened this issue Mar 18, 2016 · 1 comment
Assignees
@1ec5
Labels
build iOS Mapbox Maps SDK for iOS
Milestone
ios-v3.2.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 18, 2016

All iOS SDK make targets currently invoke strip -Sx on the static and dynamic libraries. This step should be limited to make ipackage-strip and possibly make iframework SYMBOLS=NO. It doesn’t make sense for the -symbols builds, which exist for the purpose of debugging crashes, to lack debug symbols.

Per #3280 (comment), this stripping step is mostly redundant anyways. It yields only a modest size decrease with respect to the dynamic framework.

/cc @boundsj @friedbunny
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build labels Mar 18, 2016
@1ec5 1ec5 self-assigned this Mar 18, 2016
@1ec5 1ec5 added this to the ios-v3.2.0 milestone Mar 18, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 18, 2016

Never mind. I misread the script; we’re only performing the extra stripping on symbolless builds.

@1ec5 1ec5 closed this as completed Mar 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
ios-v3.2.0
Development

No branches or pull requests
1 participant
@1ec5