Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Enforce Wrap At Java LatLng Level #4522

Closed
bleege opened this issue Mar 29, 2016 · 3 comments
Closed

Enforce Wrap At Java LatLng Level #4522

bleege opened this issue Mar 29, 2016 · 3 comments
Assignees
Labels
Android Mapbox Maps SDK for Android refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@bleege
Copy link
Contributor

bleege commented Mar 29, 2016

While working on #4444 we discovered that Core GL is no longer wrapping all Longitude values for the C++ LatLng objects that it generates and then passes to the Java LatLng (done for anti merdian), which means that the SDK can't guarantee that they're wrapped. This is important as it's been a tacitly compatible with the Google Maps API LatLng until then.

To resolve this let's make sure that both Latitude and Longitude values are clamped to their respective ranges and deprecate the stopgap LatLng.wrap() method. Let's also do a thorough dependency evaluation to ensure that all uses are covered.

Related Issues: #4475 and #4477

/cc @mapbox/mobile

@bleege bleege added refactor Android Mapbox Maps SDK for Android labels Mar 29, 2016
@jfirebaugh
Copy link
Contributor

For better or worse, we committed to unwrapped LatLng for 4.0.0, and that forms part of the public API. We can't change the wrapping semantics again until the next major version: 5.0.

@bleege
Copy link
Contributor Author

bleege commented Mar 29, 2016

We can't change the wrapping semantics again until the next major version: 5.0.

Yep. This is a semver change.

@bleege bleege added SEMVER-MAJOR Requires a major release according to Semantic Versioning rules and removed SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Mar 29, 2016
@cammace cammace added this to the android-v5.0.0 milestone Nov 9, 2016
@cammace
Copy link
Contributor

cammace commented Nov 9, 2016

Added to 5.0.0 Milestone.

cc: @mapbox/android

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

No branches or pull requests

4 participants