Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update Android NDK - Take 2 #5123

Closed
bleege opened this issue May 24, 2016 · 12 comments
Closed

Update Android NDK - Take 2 #5123

bleege opened this issue May 24, 2016 · 12 comments
Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl

Comments

@bleege
Copy link
Contributor

bleege commented May 24, 2016

We tried to update the NDK to the latest version (11c) in #5092 but ultimately had to rollback ( 6abd3d7 ) as it crashed the TestApp at runtime ( #5108 ). Let's try to update again after Android 4.1.0 FINAL ships.

/cc @mapbox/mobile @kkaefer @jfirebaugh @tmpsantos @brunoabinader

@bleege bleege added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl labels May 24, 2016
@Fintasys
Copy link

Thanks for the information!
I still get the error when I try to run my android app. I already cleaned all caches & rebuild. Can anyone tell me what to do to get my app working again?

@bleege
Copy link
Contributor Author

bleege commented May 24, 2016

@Fintasys Can you tell us more about your app? Specifically which version of the SDK are you using?

@Fintasys
Copy link

@bleege sure, I work with the Mapbox SDK 4.1.0-SNAPSHOT. It's at the moment only the map and I tested it on Android 5.1.1. If you need more specific information, let me know.
I understood that you rolled back, doesn't that mean the SNAPSHOP should work again?

@bleege
Copy link
Contributor Author

bleege commented May 25, 2016

Thanks for the specifics about what version of the SDK the app is using. Yep, the latest SNAPSHOT was built using the new (and now reverted) NDK. We tried releasing a new SNAPSHOT this afternoon but ran into another issue in #5126 that is currently preventing us from releasing a new version. We hope to have this resolved ASAP and have a new working SNAPSHOT available.

@bleege
Copy link
Contributor Author

bleege commented May 25, 2016

@Fintasys FYI... I just published a new 4.1.0-SNAPSHOT and things are working again. We'll revisit this ticket and the new NDK in the next release.

@bleege
Copy link
Contributor Author

bleege commented May 31, 2016

For more back story on the current process and timing --> #5126 (comment)

@tmpsantos
Copy link
Contributor

@kkaefer we should probably update to NDK 12 that was just released.

See https://code.google.com/p/android/issues/detail?id=212637#c2 for details. It could potentially remove some hacks we have on the code.

The NDK download website was not updated yet (as of now) but the download link works:
http://dl.google.com/android/repository/android-ndk-r12-linux-x86_64.zip

@bleege
Copy link
Contributor Author

bleege commented Jun 13, 2016

Good catch @tmpsantos on NDK 12. Google's been pushing it via Android Studio automatic updates for the past week (no direct download).

@bleege
Copy link
Contributor Author

bleege commented Jun 30, 2016

Related ticket is #5521

@bleege
Copy link
Contributor Author

bleege commented Jun 30, 2016

Now that Mapbox Android 4.1.0 has been released ( #5510 ) we'll need to update the NDK in order to get the nightly SNAPSHOTS building again (either that or revert the Makefile's build type to Release). Since this has to do with updating things in Mason I've asked @tmpsantos @kkaefer if they have time to implement this.

@kkaefer
Copy link
Member

kkaefer commented Jul 1, 2016

#5533

@bleege
Copy link
Contributor Author

bleege commented Jul 1, 2016

@kkaefer is working on upgrading the project to NDK 12 in #5533. Closing this issue in favor of his work there.

@bleege bleege closed this as completed Jul 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

No branches or pull requests

4 participants