Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fabric build output should be compatible with Fabric distribution system #5903

Closed
boundsj opened this issue Aug 8, 2016 · 4 comments
Closed
Assignees
Labels
bug build good first issue Good for newcomers iOS Mapbox Maps SDK for iOS
Milestone

Comments

@boundsj
Copy link
Contributor

boundsj commented Aug 8, 2016

I'm finding that the last iOS release that appears to be compatible with Fabric is ios-v3.2.3. In ios-v3.3.0-alpha.1 we migrated iOS and macOS targets to checked in Xcode projects. Some part of this change appears to have broken the way an app using the Mapbox SDK via Fabric pulls in Objective-C categories. This results in a runtime error:

[NSProcessInfo mgl_isInterfaceBuilderDesignablesAgent]: unrecognized selector sent to instance ...

Digging a bit deeper, ios-v3.3.0-alpha.1 actually broke projects that use the static framework entirely. So, if you used 3.3.0-alpha.1 to 3.3.0-alpha.3 you could not even build an app using the Fabric project template.

In ios-v3.3.0-beta.1 we fixed an issue where applications could not link to the Mapbox library as a static lib. However, it appears that more changes are probably required to regain compatibility with Fabric.

cc @friedbunny @1ec5 @incanus

@boundsj boundsj added the iOS Mapbox Maps SDK for iOS label Aug 8, 2016
@boundsj boundsj added this to the ios-v3.4.0 milestone Aug 8, 2016
@boundsj boundsj added the bug label Aug 8, 2016
@1ec5
Copy link
Contributor

1ec5 commented Aug 9, 2016

Probably related to 7a38e56. We should verify the statement in that commit message that -ObjC in the static framework build target is sufficient for getting the SDK’s category methods into the final built binary.

@boundsj boundsj self-assigned this Aug 12, 2016
@boundsj boundsj added the build label Aug 15, 2016
@boundsj
Copy link
Contributor Author

boundsj commented Aug 18, 2016

@1ec5 @incanus adding -ObjC to the Fabric generated project allows an app made with the project to run fine using the latest Fabric build output from master. I get the sense from looking at the add/remove -ObjC flag oscillations over the last year that we should probably go ahead and revert 7a38e56, unfortunately, just for Fabric. Ok?

@1ec5
Copy link
Contributor

1ec5 commented Aug 18, 2016

We'd have to add a whole lot more of the C function hack because we have a lot more categories than we used to.

@boundsj boundsj modified the milestones: ios-future, ios-v3.4.0 Aug 19, 2016
@1ec5 1ec5 added the good first issue Good for newcomers label Oct 18, 2016
@boundsj
Copy link
Contributor Author

boundsj commented May 12, 2017

Closing ref #8969

@boundsj boundsj closed this as completed May 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug build good first issue Good for newcomers iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

2 participants