Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Offsets should be flipped vertically on macOS #6066

Closed
1ec5 opened this issue Aug 18, 2016 · 4 comments
Closed

Offsets should be flipped vertically on macOS #6066

1ec5 opened this issue Aug 18, 2016 · 4 comments
Assignees
Labels
bug good first issue Good for newcomers macOS Mapbox Maps SDK for macOS runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 18, 2016

In the style specification, the y value of a property like fill-translate is defined as the number of pixels from the top. By contrast, offsets are normally measured from the bottom of the screen or view on macOS. In order to simplify calculations, the value exposed to the developer via the runtime styling API should be consistent with the system’s standard origin. This will become especially important once we replace the NSArray representation with a CGVector (#5947).

/cc @frederoni

@1ec5 1ec5 added bug macOS Mapbox Maps SDK for macOS runtime styling labels Aug 18, 2016
@jfirebaugh jfirebaugh added this to the ios-v3.4.0 milestone Sep 21, 2016
@jfirebaugh
Copy link
Contributor

Adding to the 3.4.0 milestone -- we need to implement this now or keep the existing behavior at least until a semver major version.

@1ec5
Copy link
Contributor Author

1ec5 commented Sep 21, 2016

This only applies to macOS; the origin is at the top-left on iOS. The macOS SDK hasn't reached v1.0.0 yet, so I'm not terribly concerned about backwards compatibility there.

@boundsj boundsj removed this from the ios-v3.4.0 milestone Sep 21, 2016
@boundsj
Copy link
Contributor

boundsj commented Sep 21, 2016

In that case, I'm going to remove the 3.4.0 milestone.

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 9, 2017

Fixed in #7636 on the release-ios-v3.4.0 branch.

@1ec5 1ec5 closed this as completed Jan 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug good first issue Good for newcomers macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

No branches or pull requests

3 participants