Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLMapView.style is not key-value compliant #6096

Closed
1ec5 opened this issue Aug 19, 2016 · 1 comment
Closed

MGLMapView.style is not key-value compliant #6096

1ec5 opened this issue Aug 19, 2016 · 1 comment
Assignees
@1ec5
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 19, 2016

MGLMapView’s style method is implemented as a factory method, returning a newly allocated MGLStyle object every time it’s called. But it should be a property and a KVO-compliant one at that: MGLMapView should own an MGLStyle object that it holds onto until styleURL changes.

/cc @frederoni
@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Aug 19, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 19, 2016
@1ec5 1ec5 mentioned this issue Aug 19, 2016
Merged
9 tasks
@1ec5 1ec5 mentioned this issue Sep 26, 2016
Closed
@boundsj boundsj added the release blocker Blocks the next final release label Oct 31, 2016
@frederoni frederoni assigned frederoni and unassigned 1ec5 Nov 7, 2016
@frederoni frederoni mentioned this issue Nov 7, 2016
Closed
@boundsj boundsj assigned 1ec5 and unassigned frederoni Nov 21, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 29, 2016

Fixed in #6097.

@1ec5 1ec5 closed this as completed Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
3 participants
@boundsj @frederoni @1ec5