Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

-[MGLMapViewDelegate mapView:viewForAnnotation:] causes assertion failure if upgrading from v3.3.x #6100

Closed
1ec5 opened this issue Aug 20, 2016 · 0 comments
Assignees
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS release blocker Blocks the next final release
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 20, 2016

Prior to #5882, -[MGLMapViewDelegate mapView:viewForAnnotation:] was only called for “user-contributed” annotations, never for the user location annotation. Now that it’s additionally called for the user location annotation, the most obvious implementation of this method will trip this assertion unless MGLUserLocationAnnotationView or a user-contributed annotation class is specifically accounted for. Instead of asserting, we should simply ignore the returned annotation view. We can consider making it a hard assertion in a future release.

/cc @friedbunny @frederoni

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS annotations Annotations on iOS and macOS or markers on Android release blocker Blocks the next final release labels Aug 20, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 20, 2016
@friedbunny friedbunny self-assigned this Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS release blocker Blocks the next final release
Projects
None yet
Development

No branches or pull requests

2 participants