Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

JNI cleanup/refactor #6533

Closed
tobrun opened this issue Sep 30, 2016 · 1 comment
Closed

JNI cleanup/refactor #6533

tobrun opened this issue Sep 30, 2016 · 1 comment
Assignees
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@tobrun
Copy link
Member

tobrun commented Sep 30, 2016

We need to find a way to make our current jni.cpp implementation a bit more manageable.
Using jni.hpp has given us a modern type safe wrapper c++14 approach to the jni but it doesn't help us manage the amount of configuration we currently need to do. We should look into structuring the content differently or approach the idea in a different way.

cc @mapbox/android

@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Sep 30, 2016
@jfirebaugh
Copy link
Contributor

  • Most of jni.cpp is using the low-level wrappers. Switching to the high-level wrappers will cut down on a lot of boilerplate.
  • Code in jni.cpp should be split out into individual files for each native type.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

No branches or pull requests

3 participants