Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MapboxAccountManager refactor #6534

Closed
tobrun opened this issue Sep 30, 2016 · 2 comments
Closed

MapboxAccountManager refactor #6534

tobrun opened this issue Sep 30, 2016 · 2 comments
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@tobrun
Copy link
Member

tobrun commented Sep 30, 2016

We are looking into changing the way MapboxMapManager works. Recently this object was only responsible for managing accesstokens but recently it became responsible for managing connection changes as well. With an upcoming release I suggest is completely rework currently exposed API. I would suggest updating the name to something else eg. Mapbox.

cc @mapbox/android

@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Sep 30, 2016
@zugaldia
Copy link
Member

I would like to move this object to mapbox-java so that it can easily handle tokens for API requests too. The challenge is that as you note MapboxAccountManager:

recently it became responsible for managing connection changes as well.

I'm thinking of having a generic NetworkInfo interface without any Android deps, with the SDK providing a default implementation using Android's.

I like Mapbox instead of MapboxAccountManager too.

@zugaldia zugaldia changed the title MapboxMapManager refactor MapboxAccountManager refactor Sep 30, 2016
@ivovandongen
Copy link
Contributor

I'm thinking of having a generic NetworkInfo interface without any Android deps, with the SDK providing a default implementation using Android's.

👍 This would indeed give some more flexibility here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

No branches or pull requests

3 participants