Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

allow mutation of MGLPolygon interior polygons/holes #6576

Closed
incanus opened this issue Oct 4, 2016 · 4 comments
Closed

allow mutation of MGLPolygon interior polygons/holes #6576

incanus opened this issue Oct 4, 2016 · 4 comments
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity feature good first issue Good for newcomers iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Oct 4, 2016

Tail work from #6565. If we allow this, we can use the same facility as there to update the annotation on the fly visually.

@incanus incanus added feature iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage macOS Mapbox Maps SDK for macOS annotations Annotations on iOS and macOS or markers on Android labels Oct 4, 2016
@incanus incanus added this to the ios-future milestone Oct 4, 2016
@1ec5
Copy link
Contributor

1ec5 commented Oct 4, 2016

At first blush, it’d be trivial to also observe changes to the interiorPolygons key path of any polygon we add to the map. However, note that, since #6565 makes any polygon a shape-shifting polygon, we actually (also?) need to observe the interiorPolygons.coordinates key path. (We don’t have to recurse any further than that: unlike MapKit’s MKPolygon, MGLPolygons can’t contain islands.)

@1ec5 1ec5 modified the milestones: ios-v3.4.0, ios-future Oct 7, 2016
@1ec5
Copy link
Contributor

1ec5 commented Oct 7, 2016

Pulling into the v3.4.0 milestone. I think it would be highly desirable to ship this issue and #6583 in the same release as #6565 to simplify expectations about what we support.

@boundsj boundsj modified the milestones: ios-3.4.1, ios-v3.4.0 Oct 30, 2016
@1ec5 1ec5 removed the performance Speed, stability, CPU usage, memory usage, or power usage label Dec 5, 2016
@1ec5 1ec5 modified the milestones: ios-v3.5.0, ios-v3.4.1 Jan 24, 2017
@1ec5 1ec5 modified the milestones: ios-v3.6.0, ios-v3.5.0 Mar 10, 2017
@1ec5 1ec5 added the good first issue Good for newcomers label Mar 29, 2017
@boundsj boundsj modified the milestones: ios-future, ios-v3.6.0 Mar 31, 2017
@stale
Copy link

stale bot commented Oct 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived because of inactivity label Oct 27, 2018
@stale
Copy link

stale bot commented Dec 6, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity feature good first issue Good for newcomers iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

4 participants