Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Failing tablet tests #7221

Closed
tobrun opened this issue Nov 29, 2016 · 4 comments
Closed

Failing tablet tests #7221

tobrun opened this issue Nov 29, 2016 · 4 comments
Labels
Android Mapbox Maps SDK for Android tests

Comments

@tobrun
Copy link
Member

tobrun commented Nov 29, 2016

Some tests we run on a tablet device have a different results from phone factor devices. We need to look into optimising these delta used in those tests and look into integrating our CI tests on a tablet device instead of a phone device (this is what most developers use for day-to-day development)

Impacted tests:

cc @ivovandongen

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Nov 29, 2016
@tobrun tobrun added this to the android-v5.0.0 milestone Nov 29, 2016
@kkaefer kkaefer assigned kkaefer and unassigned kkaefer Dec 9, 2016
@tobrun
Copy link
Member Author

tobrun commented Jan 31, 2017

#7265 solves one issue of running test in both portrait and landscape mode.

@tobrun
Copy link
Member Author

tobrun commented Feb 15, 2017

One of the issues that make a test succeed on one device and fail on another is related to screensize/pixel density. Atm we have fixed delta's when comparing CameraPositions (while this works for a large range of devices, it doesn't work for all). Increasing the fixed delta is not possible as this would result in false negatives. We need to look into calculating a dynamic delta that takes in account the screensize/pixel density.

@tobrun
Copy link
Member Author

tobrun commented Jul 4, 2018

Looking into this again as I'm writing tests for #12290. I'm going to create a fixed test setup where the map is always 512px-512px large and has a pixel ratio of 1. This results in not having to provide a dynamic delta as set out in OP and we can renable tests in this package again.

cc @LukasPaczos

@tobrun
Copy link
Member Author

tobrun commented Jul 6, 2018

Done with #12304

@tobrun tobrun closed this as completed Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

No branches or pull requests

3 participants