-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Failing tablet tests #7221
Comments
#7265 solves one issue of running test in both portrait and landscape mode. |
One of the issues that make a test succeed on one device and fail on another is related to screensize/pixel density. Atm we have fixed delta's when comparing CameraPositions (while this works for a large range of devices, it doesn't work for all). Increasing the fixed delta is not possible as this would result in false negatives. We need to look into calculating a dynamic delta that takes in account the screensize/pixel density. |
Looking into this again as I'm writing tests for #12290. I'm going to create a fixed test setup where the map is always 512px-512px large and has a pixel ratio of 1. This results in not having to provide a dynamic delta as set out in OP and we can renable tests in this package again. cc @LukasPaczos |
Done with #12304 |
Some tests we run on a tablet device have a different results from phone factor devices. We need to look into optimising these delta used in those tests and look into integrating our CI tests on a tablet device instead of a phone device (this is what most developers use for day-to-day development)
Impacted tests:
cc @ivovandongen
The text was updated successfully, but these errors were encountered: