Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLCalloutView should extend UIView, not NSObject #7523

Closed
1ec5 opened this issue Dec 22, 2016 · 1 comment
Closed

MGLCalloutView should extend UIView, not NSObject #7523

1ec5 opened this issue Dec 22, 2016 · 1 comment
Assignees
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 22, 2016

The MGLCalloutView protocol extends NSObject, but the documentation for it says an instance of MGLCalloutView must be a kind of UIView, and in fact that’s the assumption this line makes. We should correct the declaration of this protocol to extend UIView as documented.

/cc @frederoni

@1ec5 1ec5 added annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Dec 22, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Dec 22, 2016
@frederoni frederoni self-assigned this Jan 9, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 11, 2017

My bad: a protocol can only extend another protocol, not a class. It turns out that we never say id <MGLCalloutView>, only UIView <MGLCalloutView>. As long as we’re consistent about that, there’s no potential for incorrect behavior.

@1ec5 1ec5 closed this as completed Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

2 participants