Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Don't disable location tracking on all gestures #7878

Closed
cammace opened this issue Jan 26, 2017 · 4 comments
Closed

Don't disable location tracking on all gestures #7878

cammace opened this issue Jan 26, 2017 · 4 comments
Assignees
Labels
Android Mapbox Maps SDK for Android feature good first issue Good for newcomers

Comments

@cammace
Copy link
Contributor

cammace commented Jan 26, 2017

While location tracking is enabled and disable on gesture is true, you should still be able to change the zoom and tilt without disabling the tracking.

cc: @tobrun

@tobrun
Copy link
Member

tobrun commented Jan 31, 2017

To put in other words the tracking should only be disabled with onScroll?

@cammace
Copy link
Contributor Author

cammace commented Jan 31, 2017

Right even rotating shouldn't dismiss it therefore, only onScroll makes sense.

@tobrun tobrun added this to the android-v5.0.0 milestone Feb 21, 2017
@tobrun
Copy link
Member

tobrun commented Feb 21, 2017

Adding this to 5.0.0 milestone, changing this kind of business logic would require a semver change.

@tobrun tobrun assigned tobrun and unassigned tobrun Feb 21, 2017
@tobrun
Copy link
Member

tobrun commented Mar 3, 2017

Capturing from convo with @cammace that this is related to changing the camera position and not related to the gestures:

/**
   * Reset the tracking modes as necessary. Animated camera position changes can reset the underlying tracking modes.
   *
   * @param cameraPosition the changed camera position
   */
  void resetTrackingModesIfRequired(CameraPosition cameraPosition) {
    if (isDismissTrackingModesForCameraPositionChange()) {
      resetTrackingModesIfRequired(cameraPosition.target != null, cameraPosition.bearing != -1);
    }
  }

cc @Guardiola31337

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants