Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Provide more descriptive error message when removing a marker that doesn't exist #7961

Closed
danswick opened this issue Feb 7, 2017 · 1 comment · Fixed by #8832
Closed
Assignees
Labels
Android Mapbox Maps SDK for Android feature

Comments

@danswick
Copy link
Contributor

danswick commented Feb 7, 2017

Platform: Android
Mapbox SDK version: 4.2.2

Steps to trigger behavior

Attempt to remove a marker that does not exist.

Expected behavior

Graceful failure with descriptive error message and/or Java exception (instead of native).

Actual behavior

Crash with an error message similar to:

void mbgl::AnnotationManager::removeAnnotation(const AnnotationID &): assertion "false" failed
@danswick danswick added Android Mapbox Maps SDK for Android feature labels Feb 7, 2017
@tobrun
Copy link
Member

tobrun commented Apr 19, 2017

We should prevent calling into core when the marker hasn't been added to the map. Adding this to the next milestone for visibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants