Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add filter accessor to layer #7978

Closed
ivovandongen opened this issue Feb 8, 2017 · 3 comments
Closed

Add filter accessor to layer #7978

ivovandongen opened this issue Feb 8, 2017 · 3 comments
Assignees
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers runtime styling

Comments

@ivovandongen
Copy link
Contributor

ATM there is only a setter for filters on Layer classes, no getter, eg Layer#getFilter().

@Jukurrpa
Copy link

Jukurrpa commented Nov 10, 2017

Hi, I just wanted to know what is the priority on this?

We built most of our design using Mapbox Studio and having access to a layer's filters would be very useful when making changes to it, for example when adding/removing filters on an existing layer while keeping the ones defined through Studio. Storing these base filters in the app or through remote config would somewhat defeat the purpose of Studio.

In the same vein, it'd also be greatly appreciated if layers exposed their source's identifier (in addition to the source layer's identifier).
Edit: same for a VectorSource's list of source layer identifiers

@1ec5 1ec5 added the good first issue Good for newcomers label Nov 11, 2017
@1ec5 1ec5 mentioned this issue Dec 12, 2017
24 tasks
@tobrun
Copy link
Member

tobrun commented Jan 4, 2018

We are going to add expression filter support to core soon and add Android accessors for it.
This issue has become obsolete.

@1ec5
Copy link
Contributor

1ec5 commented Jan 6, 2018

We are going to add expression filter support to core soon and add Android accessors for it.

#10720

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers runtime styling
Projects
None yet
Development

No branches or pull requests

7 participants