Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

-[MGLMapViewDelegate mapViewDidFailLoadingMap:withError:] error is uninformative #8398

Closed
1ec5 opened this issue Mar 14, 2017 · 3 comments
Closed
Labels
Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS refactor

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 14, 2017

The error passed into -[MGLMapViewDelegate mapViewDidFailLoadingMap:withError:] is an uninformative error. We synthesize this generic error for compatibility with MapKit because mbgl doesn’t actually tell the SDK what went wrong. Per #8377 (comment), mbgl::MapObserver::onDidFailLoadingMap() should accept the error or error message as a parameter. This would allow all the SDKs – not only the iOS and macOS SDKs – to provide more information when the map fails to load for some reason.

/cc @brunoabinader @fabian-guerra

@1ec5 1ec5 added Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS refactor labels Mar 14, 2017
@1ec5 1ec5 added this to the ios-v3.6.0 milestone Mar 14, 2017
@brunoabinader
Copy link
Member

👉 #8418.

@jfirebaugh
Copy link
Contributor

Is this a duplicate of #8086?

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 16, 2017

Yes indeed!

@1ec5 1ec5 closed this as completed Mar 16, 2017
@boundsj boundsj removed this from the ios-v3.6.0 milestone Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS refactor
Projects
None yet
Development

No branches or pull requests

4 participants