Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Migrate to GL JS–powered feedback form #8988

Closed
1ec5 opened this issue May 13, 2017 · 6 comments
Closed

Migrate to GL JS–powered feedback form #8988

1ec5 opened this issue May 13, 2017 · 6 comments
Assignees
Labels
feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 13, 2017

A map feedback form powered by GL JS will be available as an alternative to the mapbox.js-powered Map Feedback tool. We’ll want to move the native SDKs over to the new tool, even when the relevant TileJSON attribution still specifies the original tool, because the new tool will more closely match what the user sees on screen before reporting an issue.

Just as mapbox.js was able to pass the map ID into the original tool, we’ll be able to pass a style ID into the new tool. mapbox/mapbox-gl-js#4685 passes in the (undocumented) owner and id properties at the root of the style JSON object. That would require adding additional parsing logic along the lines of #6002. But a simpler approach would be to extract the owner and ID from the style URL, as long as it’s a mapbox: URL. After all, the feedback tool would use that very mapbox: URL to load the style in GL JS.

There are separate implementations of the map feedback button on Android and iOS/macOS. Note that this work is distinct from #6001 for iOS and #6013 for Android, but it may help us prepare for those features.

/cc @mollymerp @tristen @tobrun

@1ec5 1ec5 added Android Mapbox Maps SDK for Android feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels May 13, 2017
@1ec5 1ec5 added this to the ios-v3.6.0 milestone May 13, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented May 23, 2017

#9078 migrates iOS and macOS to the new feedback tool.

@zugaldia
Copy link
Member

Tracking Android work on #9090.

@1ec5 1ec5 removed the Android Mapbox Maps SDK for Android label May 23, 2017
@mollymerp
Copy link
Contributor

note that I've changed the hash order to match the gl-js hash class (zoom, center latitude, center longitude, bearing, and pitch ) and added user access_token as an additional param (necessary to display the style the user is reporting feedback on).

For example, http://path/to/my/page.html#2.59/39.26/53.07/-24.1/60 .

@mollymerp
Copy link
Contributor

eeep sorry I had to revert this back to #/lng/lat/zoom/bearing/pitch/ format due to constraints @tristen informed me of today. Apologies @1ec5 @zugaldia if this makes more work for you 🙈

@1ec5
Copy link
Contributor Author

1ec5 commented May 24, 2017

No worries. I’ve been tracking the changes in mapbox/mapbox-gl-js#4685 and have an implementation in #9078.

@1ec5
Copy link
Contributor Author

1ec5 commented May 30, 2017

Fixed for iOS and macOS in #9078 on the release-ios-v3.6.0-android-v5.1.0 branch. The fix for Android is tracked in #9090.

@1ec5 1ec5 closed this as completed May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

3 participants