This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Migrate to GL JS–powered feedback form #8988
Labels
feature
GL JS parity
For feature parity with Mapbox GL JS
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
Milestone
Comments
1ec5
added
Android
Mapbox Maps SDK for Android
feature
GL JS parity
For feature parity with Mapbox GL JS
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
labels
May 13, 2017
#9078 migrates iOS and macOS to the new feedback tool. |
Tracking Android work on #9090. |
note that I've changed the hash order to match the gl-js hash class (
|
No worries. I’ve been tracking the changes in mapbox/mapbox-gl-js#4685 and have an implementation in #9078. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature
GL JS parity
For feature parity with Mapbox GL JS
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
A map feedback form powered by GL JS will be available as an alternative to the mapbox.js-powered Map Feedback tool. We’ll want to move the native SDKs over to the new tool, even when the relevant TileJSON attribution still specifies the original tool, because the new tool will more closely match what the user sees on screen before reporting an issue.
Just as mapbox.js was able to pass the map ID into the original tool, we’ll be able to pass a style ID into the new tool. mapbox/mapbox-gl-js#4685 passes in the (undocumented)
owner
andid
properties at the root of the style JSON object. That would require adding additional parsing logic along the lines of #6002. But a simpler approach would be to extract the owner and ID from the style URL, as long as it’s a mapbox: URL. After all, the feedback tool would use that very mapbox: URL to load the style in GL JS.There are separate implementations of the map feedback button on Android and iOS/macOS. Note that this work is distinct from #6001 for iOS and #6013 for Android, but it may help us prepare for those features.
/cc @mollymerp @tristen @tobrun
The text was updated successfully, but these errors were encountered: