Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Make feedback button localizable #9215

Closed
evgzor opened this issue Jun 8, 2017 · 7 comments
Closed

Make feedback button localizable #9215

evgzor opened this issue Jun 8, 2017 · 7 comments
Labels
archived Archived because of inactivity iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS

Comments

@evgzor
Copy link

evgzor commented Jun 8, 2017

iOS 10.3
3.5.4

Steps to trigger behavior

  1. Change general language of iOS device to German
  2. Run app with mapbox integrated
  3. Press info button
  4. Observe the result

Expected behavior

All items is localized or at least allow to be localize with any workarounds

Actual behavior

Some of the menu items are not localized:
screenshot 2017-06-08 10 09 32

@Guardiola31337 Guardiola31337 added the iOS Mapbox Maps SDK for iOS label Jun 8, 2017
@tobrun tobrun added the localization Human language support and internationalization label Jun 8, 2017
@1ec5
Copy link
Contributor

1ec5 commented Jun 8, 2017

The German localization is incomplete. If you can, please consider contributing to the localization. Thank you!

@evgzor
Copy link
Author

evgzor commented Jun 8, 2017

@1ec5 I requested access to join the team. Could u please approve?

@1ec5
Copy link
Contributor

1ec5 commented Jun 9, 2017

Welcome to the translator team, @evgzor!

@evgzor
Copy link
Author

evgzor commented Jun 9, 2017

@1ec5 Many thanks for the approvement of invitation. We will translate all German strings. However, I did not find for translation string "Improve This Map". Could u please explain how possible to add it or where is it?

@1ec5
Copy link
Contributor

1ec5 commented Jun 9, 2017

Ah, I didn’t realize you were referring to that particular item. The attribution items, including the “Improve This Map” button, come from the TileJSON files used by the sources in the current style. (For example, the default Mapbox Streets v9 style uses the Mapbox Streets v7 source, which defines the top three attribution items.) mapbox/tilejson-spec#20 tracks allowing TileJSON sources to provide localized attribution items.

Given that we’re already overriding the feedback link’s URL as of #9078, it isn’t unrealistic to override the “Improve This Map” string and make it localizable like it used to be (before #5999 landed). In fact, that would enable us to remove the fancy capitalization code added in #7651.

@1ec5 1ec5 changed the title Info button menu item is not localized in iOS SDK Make feedback button localizable Jun 9, 2017
@1ec5 1ec5 added the macOS Mapbox Maps SDK for macOS label Jun 9, 2017
@evgzor
Copy link
Author

evgzor commented Jun 14, 2017

@1ec5 Could u please let me know when it would be localized for "Improve This Map" – "Verbessere diese Karte" in German ?

@stale stale bot added the archived Archived because of inactivity label Nov 6, 2018
@stale
Copy link

stale bot commented Nov 30, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

4 participants