Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbox Streets GL: refining roads #76

Closed
nickidlugash opened this issue Apr 1, 2015 · 4 comments
Closed

Mapbox Streets GL: refining roads #76

nickidlugash opened this issue Apr 1, 2015 · 4 comments
Assignees

Comments

@nickidlugash
Copy link
Contributor

screen shot 2015-04-01 at 1 34 48 pm
screen shot 2015-04-01 at 1 35 25 pm
screen shot 2015-04-01 at 1 59 33 pm

Summary of current road styling:

1 (widest) 2 3 4 5 Hairline
ORANGE Motorway - Motorway_link -
YELLOW Trunk - - -
WHITE - Main Street Service / driveway Path (dotted)
LT GREY - - Street_limited -
DK GREY - - - - - Major_rail / minor_rail (with tracks), Aerialway

Bridges: Same as roads, but with butt caps for the casings.

Tunnels: For orange and yellow roads, these are are a lighter shade/lower saturation. For white roads and light grey roads, these are the color of the casing.

Still to add/consider:

  • Tunnels: These need some refining. My strong preference is for these to be a lowered opacity, rather than a lighter color, but that requires per-layer opacity to be implemented.
  • Rails: Currently rail bridges and tunnels are styled the same as roads. In the past I've often differentiated between these, but I wonder if that's necessary? Whether a train goes across tracks on a bridge or in a tunnel doesn't really affect train passengers or most people looking at the map.
  • Service and Driveway classes: Currently service and driveway are one layer. Should they be two (with driveway thinner?). Should we not style driveways at all? The reason to collapse them into one style was to reduce # of layers, since driveways are very minor features and maybe not worthy of their own layer.
  • Paths: All paths are one layer, and optimized for cities. Again, this is to reduce # of layers. Should we pull out some path types? Ski slopes? Steps? Footways? I'm leaning towards no.
@nickidlugash nickidlugash self-assigned this Apr 1, 2015
@samanpwbb samanpwbb added this to the Mapbox Streets GL milestone Apr 1, 2015
@nickidlugash
Copy link
Contributor Author

@samanpwbb I just pushed a stylesheet with updated styling for mid-zoom streets. Main road casings also come in later now. Let me know what you think.

screen shot 2015-04-03 at 12 31 22 pm

@1ec5
Copy link
Contributor

1ec5 commented Apr 3, 2015

The white outline around the highway shields is a little too thick. When it bleeds into nearby minor road fills (see “9A” center-left), the outline can almost look like a continuation of the road. Is that white outline even necessary? On dark backgrounds the white will stand out; on light backgrounds the black outline will make the shape discernible.

@nickidlugash
Copy link
Contributor Author

@1ec5 – Thanks for the feedback! @samanpwbb is already removing these. Also, we do have a ticket for everything sprite-related if you have more feedback.

@nickidlugash
Copy link
Contributor Author

More specific issues captured in other tickets now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants