Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License of closed source library libandroid-navigation #1391

Closed
karussell opened this issue Oct 4, 2018 · 4 comments · Fixed by #1494
Closed

License of closed source library libandroid-navigation #1391

karussell opened this issue Oct 4, 2018 · 4 comments · Fixed by #1494

Comments

@karussell
Copy link

Thanks a lot @danesfeder & others for pushing forward such an amazing open source library. We (as GraphHopper) appreciate that Mapbox invests into the open source community.

Now that the libandroid-navigation is merged into master this creates uncertainty regarding trust and license. What is the license of the closed source library and which (distribution etc) rights does one have? What actually does it do? Does it use the internet or "just" for offline purposes.

Why not add this library for commercial distribution later in the pipeline and use an open source replacement with the functionality from before the merge of this library?

I'm not saying that you should open source this library. Furthermore we are open to contributions. (already contributed some tiny things like #1108)

What can we do that you re-evaluate your current strategy :) ?

Initially asked at #1265

@danesfeder
Copy link
Contributor

Hey @karussell 👋sorry for the delayed response here.

What actually does it do? Does it use the internet or "just" for offline purposes.

The shared Navigator library and functionality added in #1265 serves to bring many improvements to our core routing / processing logic. Its core functionality is written in C++ similar to our Maps SDK, which provides major performance enhancements.

Outside of performance and reliability, it makes it much easier to align platforms (iOS v. Android for example), where previously we were in a constant state of flux for platform parity. @mcwhittemore outlined a similar explanation in #1265 (comment).

I hope this helps provide some context into the benefits of this library.

@karussell
Copy link
Author

Thanks for the answer. I understand the intent. Is the library using the internet or does it collect data that is then send over the internet?

What about the usage and distribution license? And would you accept contributions to make the library optional?

@mcwhittemore
Copy link
Contributor

@karussell - Sorry for the slow reply here. The license for Navigator is the Mapbox TOS license. I was hoping to have a landing page about Navigator to point to so you could read the license, but that is a few weeks out still. Here is the text of the license.

Copyright © 2018 Mapbox, Inc. You may use this code with your Mapbox account and under the Mapbox Terms of Service (available at: https://www.mapbox.com/tos/). All other rights reserved.

@karussell
Copy link
Author

karussell commented Nov 2, 2018

Oh, wow. Really unexpected and unusual way for a repository on Github and especially for Mapbox. Not unrightful, please don't get me wrong, but disappointed. Time for a real open source fork :)

Still, we appreciate your work and hope that you decide to change this proprietary strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants