Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route not properly centered after clicking on route preview button #1718

Closed
Guardiola31337 opened this issue Feb 1, 2019 · 6 comments
Closed
Assignees
Labels
bug Defect to be fixed.

Comments

@Guardiola31337
Copy link
Contributor

The route is not properly centered after clicking on the route preview button in both landscape and portrait 👀

route_preview_not_centered_properly_plus_lifecycle_issue_drawing_previous_route

Apparently the camera bounds are still relying on the origin. Noting that I was re-routed a couple of times before route preview button was clicked.

Also if you see the video carefully there's some lifecycle issue because when rotating the first time to landscape the previous route gets displayed and it kept displaying even after rotating to portrait.

This seems kind of similar to #1673 (comment) and the changes introduced in #1688 could be related.

@Guardiola31337 Guardiola31337 added bug Defect to be fixed. topic: camera labels Feb 1, 2019
@danesfeder
Copy link
Contributor

The Geometry passed through RouteProgress in #1895 will help provide fresh data in DynamicCamera to hopefully address this ticket.

@Guardiola31337
Copy link
Contributor Author

@abhishek1508 it'd be great to fix this in the 1.0 UI SDK.

@abhishek1508
Copy link
Contributor

Let's verify/fix.
cc @JunDai @cafesilencio @langsmith

@cafesilencio
Copy link
Contributor

It looks like this issue has been resolved. When testing I see the route centered in the screen in both landscape and portrait modes.

20200723_101709

20200723_101811

@Guardiola31337
Copy link
Contributor Author

@cafesilencio have we tested 👇 too?

Noting that I was re-routed a couple of times before route preview button was clicked.

I'd swear this is still an issue as we didn't change any DynamicCamera logic 🤔

Could we verify 🙏?

@cafesilencio
Copy link
Contributor

I retested with SummaryBottomSheetActivity and used a mock location app to force several reroutes. After each reroute I clicked the route preview button and the current route was always centered in the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

No branches or pull requests

4 participants