-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route not properly centered after clicking on route preview button #1718
Comments
The |
@abhishek1508 it'd be great to fix this in the |
Let's verify/fix. |
@cafesilencio have we tested 👇 too?
I'd swear this is still an issue as we didn't change any Could we verify 🙏? |
I retested with SummaryBottomSheetActivity and used a mock location app to force several reroutes. After each reroute I clicked the route preview button and the current route was always centered in the screen. |
The route is not properly centered after clicking on the route preview button in both landscape and portrait 👀
Apparently the camera bounds are still relying on the
origin
. Noting that I was re-routed a couple of times before route preview button was clicked.Also if you see the video carefully there's some lifecycle issue because when rotating the first time to landscape the previous route gets displayed and it kept displaying even after rotating to portrait.
This seems kind of similar to #1673 (comment) and the changes introduced in #1688 could be related.
The text was updated successfully, but these errors were encountered: