Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way name outdated after resuming navigation #1886

Closed
Guardiola31337 opened this issue Apr 15, 2019 · 5 comments · Fixed by #1894
Closed

Way name outdated after resuming navigation #1886

Guardiola31337 opened this issue Apr 15, 2019 · 5 comments · Fixed by #1894
Labels
bug Defect to be fixed.
Milestone

Comments

@Guardiola31337
Copy link
Contributor

After integrating #1880 we've noticed that the way name sticks outdated after resuming a navigation session 👀

way_name_outdated

After debugging it seems

is always returning an empty list when bringing the app into the foreground after backgrounding it.

Maps SDK upstream ticket mapbox/mapbox-gl-native#14422 and fix mapbox/mapbox-gl-native#14426

cc @tobrun

@zugaldia
Copy link
Member

Quick update to report that mapbox/mapbox-gl-native#14426 is now reviewed and approved. The current goal is to merge this change in time for the upcoming beta.1 release of the mojito release.

cc: @tobrun @LukasPaczos for confirmation.

@Guardiola31337
Copy link
Contributor Author

@zugaldia
Could we do a patch release (v7.3.2) after confirming the fix solves the regression so we will be able to include it in our next release?

@tobrun
Copy link
Member

tobrun commented Apr 16, 2019

Since the release is still two weeks out, I feel a patch is justified. Need to do some a bit more testing on mapbox/mapbox-gl-native#14426 tomorrow and can work on releasing it after.

@Guardiola31337
Copy link
Contributor Author

Awesome @tobrun thanks for the update! We will test it downstream as well as soon a SNAPSHOT including mapbox/mapbox-gl-native#14426 is ready and report back here.

@Guardiola31337
Copy link
Contributor Author

Confirming that testing with 7.4.0-SNAPSHOT including mapbox/mapbox-gl-native#14426 we're not able to reproduce OP anymore. We're good on doing a patch release 🚀

cc @tobrun @zugaldia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants