Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundabout icon assumes right-hand driving #575

Closed
1ec5 opened this issue Sep 1, 2017 · 4 comments
Closed

Roundabout icon assumes right-hand driving #575

1ec5 opened this issue Sep 1, 2017 · 4 comments
Assignees
Labels
bug Something isn’t working topic: instructions

Comments

@1ec5
Copy link
Contributor

1ec5 commented Sep 1, 2017

For roundabouts, the turn banner shows an icon that goes counterclockwise, even in countries that drive on the left:

bogeshole

Even without Project-OSRM/osrm-backend#2772 / Project-OSRM/osrm-backend#4415, we can flip the icon based on whether the roundabout maneuver’s initial and final headings indicate a left or right turn, since those headings correspond to the entrance maneuver, as opposed to the exit maneuver.

I think this issue will be unaffected by Project-OSRM/osrm-backend#4358.

/cc @bsudekum @frederoni @MoKob

@1ec5 1ec5 added bug Something isn’t working topic: instructions labels Sep 1, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Sep 1, 2017

The fix would go on this line or thereabouts.

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 2, 2017

Similar to #640, I think fixing this issue would entail looking at the enter-roundabout step’s maneuver direction: if it’s to the left, then flip the roundabout icon horizontally.

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 30, 2017

I think fixing this issue would entail looking at the enter-roundabout step’s maneuver direction: if it’s to the left, then flip the roundabout icon horizontally.

Here’s an example where the step’s direction (derived from the maneuver’s modifier in the Directions API response) will be slightRight when using a roundabout to continue going straight, whether or not includesExitRoundaboutManeuver (roundabout_exits) is set. However, note that the direction will be the overall direction of travel in the case of a “roundabout turn” maneuver.

/cc @mcwhittemore

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 2, 2018

Fixed in #911.

/cc @bsudekum

@1ec5 1ec5 closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working topic: instructions
Projects
None yet
Development

No branches or pull requests

3 participants