-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale Widget Plugin #11
Comments
Hi Could you help with that? Maybe not a plugin but i need to change some attributes for map like in iOs Thanks. |
@samoilovich the code in #17 was just a WIP and I haven't been able to pick this up again. That said, we are aware that we are missing this functionality but we also haven't heard many request for it either (other than above). If this is an immediate need on your end, you can roll your own and we do accept pull requests ;) |
@tobrun any updates on this? |
I have added scale bar to map. It was as an additional view. |
@hurrba @samoilovich we definitely welcome contributions, we have some general instructions here and we're available for any questions you might have. Regarding of whether this should be included or not as part of the Maps SDK, that's a great question. I think that it's probably easier to initially build out the feature and iterate it here but we're hoping to get this kind of feedback (thanks!) as we're constantly evaluating what belongs here and what belongs in the core SDK. |
As someone that has used MapBox in both iOS and Android one of the biggest issues is learning the API because it is not one of the easiest to master. Even then you master the iOS version and the Android is so different. In my honest opinion this is one of the biggest drawbacks, that there is no 1:1 mapping of functions or variable names. It needs to be standardised and you need a plan going forward to ensure the same features are available in both platforms. |
@pacomacman thank you very much for this feedback, this is something we've heard before and it's top of mind whenever we plan new features and components. While we try to keep consistency in naming across platforms, sometimes platform-specific conventions, or differences in the technical implementation, make our public APIs diverge in name. Please share any specific instances that were particularly confusing or challenging. While changing API names isn't always feasible (it'd break the public API and require a major SEMVER release) it helps us improve our documentation and guide future naming strategies. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It would be great to have a scale bar! |
@paulsUsername , @Chaoba is working on this in #955 👍 |
A scale widget plugin allows to place a scalebar on a Mapbox map.
iOS is bringing this feature to their SDK in mapbox/mapbox-gl-native#7631. We could potentially implement this as a plugin instead. This fits in our to decouple our map SDK more into smaller pluggable components.
cc @zugaldia
The text was updated successfully, but these errors were encountered: