You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi!
I'm a developer working on GetODK in our mobile app we use Mapbox and the annotation plugin which we wanted to update to the newest version 9:0.9.0 but we discovered regression.
In our app we allow selecting points on a map and we draw lines between them (it's geo shape or geo trace). We also allow dragging those points and redrawing those lines while dragging so that everything is smooth:
The problem is that after updating to 9:0.9.0. The dragging process is terminated immediately after starting when we update lines (calling AnnotationManager.update(T annotation).
The problem seems to be in updating lines because when we call AnnotationManager.update(T annotation) -> updateSource() -> draggableAnnotationController.onSourceUpdated() -> stopDragging(draggedAnnotation) and as result our dragging process is immediately stoped.
It wasn't the case in v9:0.8.0. Could someone explain why this behavior changed and why when we want to update lines the dragging process is terminated?
The text was updated successfully, but these errors were encountered:
grzesiek2010
changed the title
Problem with updating lines on dragging with the newest version of the annotation plugin
Problem with dragging points and updating lines in the newest version of the annotation plugin
Feb 19, 2021
Hi!
![ezgif com-video-to-gif (8)](https://user-images.githubusercontent.com/3276264/108526303-3f42b600-72d1-11eb-9b73-650cdfdf7fed.gif)
I'm a developer working on GetODK in our mobile app we use Mapbox and the annotation plugin which we wanted to update to the newest version 9:0.9.0 but we discovered regression.
In our app we allow selecting points on a map and we draw lines between them (it's geo shape or geo trace). We also allow dragging those points and redrawing those lines while dragging so that everything is smooth:
The problem is that after updating to 9:0.9.0. The dragging process is terminated immediately after starting when we update lines (calling
AnnotationManager.update(T annotation)
.The implementation is here https://github.com/getodk/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/geo/MapboxMapFragment.java#L914
we override
onAnnotationDrag
to update points and lines.The problem seems to be in updating lines because when we call
AnnotationManager.update(T annotation)
->updateSource()
->draggableAnnotationController.onSourceUpdated()
->stopDragging(draggedAnnotation)
and as result our dragging process is immediately stoped.It wasn't the case in v9:0.8.0. Could someone explain why this behavior changed and why when we want to update lines the dragging process is terminated?
The text was updated successfully, but these errors were encountered: