Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol options does not support kotlinx serialization #1195

Open
guillermolc opened this issue Aug 16, 2021 · 1 comment
Open

Symbol options does not support kotlinx serialization #1195

guillermolc opened this issue Aug 16, 2021 · 1 comment

Comments

@guillermolc
Copy link

Good morning, I would like to know if you could modify the Symbol Options class in the data property, so that it accepts JsonElements from Kotlinx.

Example:

public class SymbolOptions extends Options {
private JsonElement data; ---> This only accept a com.google.gson.JsonElement
}

And need

public class SymbolOptions extends Options {
private JsonElement data; ---> kotlinx.serialization.json.JsonElement
}

It would be nice if you could apply this, especially since many people are starting to use this extension in cross-platform projects and import Gson and Kotlinx Serialization at the same time, it does not make sense :)

Good day

@Nek-12
Copy link

Nek-12 commented Feb 10, 2022

Seems to me like a poor design choice. Including arbitrary in-memory data for each annotation should likely be done using Any? type or at least String? so that we can use our own serialization engines. Ideally, we shouldn't be burdened by whatever serialization library MapBox uses under the hood. Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants