-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geocoder Search Bar #14
Comments
It would be nice to keep the concept of map plugins focused to functionality that’s contained in the map itself. The functionality proposed here is akin to how the navigation SDK – as a separate library – vends its own UI that has a map view as its centerpiece. That isn’t really a consideration for mapbox-gl-geocoder, which is designed as an ornament in the map itself, similar to the compass button provided by the iOS SDK. Another way of looking at it is that, on iOS, it would be more helpful to provide a view controller – perhaps a special version of UISearchController and UITableViewController that work together. By contrast, a standalone UISearchBar provides little additional functionality and would require the developer to manage integration with a UITableView themselves. Yet as soon as a library vends a view controller, it moves well beyond the scope of the map SDK, taking over the window instead of enhancing a particular view within the window. |
Yeah. I think we need to explore whether we want to use the plugins repo to house plugins that solely use the Maps SDK, or to also include plugins intended to bridge the Maps SDK with other other Mapbox libraries (such as geocoding). |
Would it make more sense to include this functionality within MapboxGeocoder.swift directly instead? |
Like the other service libraries, MapboxGeocoder.swift is currently designed to be a lightweight wrapper around the Geocoding API proper, akin to the functionality provided by the Mapbox JavaScript SDK. So far it seems that our non-UI libraries are language-oriented (e.g., Swift) whereas the UI libraries are platform-oriented (e.g., iOS). At the risk of repo proliferation, a separate UI library could depend on MapboxGeocoder.swift as an implementation detail, just as the navigation SDK depends on MapboxDirections.swift as an implementation detail. |
Android Places Plugin has landed. I have been working on a search bar with iOS on the side, but am still a little unsure about where it would live. There is also a case for including it as an example with the MapboxGeocoder.swift library, as @captainbarbosa mentioned. |
Hi, any news about the iOS version of build in search bar? |
Any update on this? |
We currently don't have plan to introduce a geocoder search bar plugin for this repository while we focus on other roadmap priorities. We're considering including a search bar as an integrated component of MapboxGeocoder.swift or at least include an example there, but have no timeline on when this would be implemented. |
An iOS version of the mapbox-gl-geocoder would be helpful for developers. Could allow people to more easily incorporate MapboxGeocoder.swift.
It would require an additional dependency, so we would need to decide whether we want to support Carthage in this library.
It would likely be a
UISearchBar
with a 4-5 rowUITableView
that pops over the map, and return an array that can be mapped by the user.cc @captainbarbosa @1ec5
The text was updated successfully, but these errors were encountered: