-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails on buckets containing dots #139
Comments
Hmm, I think I somehow had an old version of this installed. Running on latest works now. |
Ok, after a lot of painful investigation, I have discovered that there is an issue. mapbox-tile-copy uses s3urls version 1.5.3 which fixed the dot issue. But mapbox-tile-copy uses tilelive-s3 version 6.5.1 which uses s3urls^1.4.0 which in my case seems to mean that I got two versions of s3urls installed. tilelive-s3's version is what calculates the bucket name, so it gets it wrong. Ohhh...I think it's because |
Wow. The fix, after all that seems to be straightforward: just upgrade @mapbox/tilelive-s3 to 7.0.1. Although I haven't run the tests, so it's possible that breaks other things. |
I ran into the same issue, and have decided to push to URL without dots and will migrate to proper s3 bucket afterwards. |
For me, it seems I can successfully upload to buckets that don't contain dots in the name. Otherwise it fails:
This is obviously a big problem for serving tiles from S3 as a static website.
This is basically a duplicate of #53, which was apparently fixed by a third-party library update, but...it's now back?
The text was updated successfully, but these errors were encountered: