Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linking platform-specific #290

Closed
kkaefer opened this issue Nov 30, 2016 · 3 comments
Closed

Make linking platform-specific #290

kkaefer opened this issue Nov 30, 2016 · 3 comments

Comments

@kkaefer
Copy link
Member

kkaefer commented Nov 30, 2016

As a follow up to #216: mason link currently creates all symlinks in a shared mason_packages/.link folder. However, we should instead create .link folders per architecture, e.g. mason_packages/osx-x86_64/.link.

/cc @daniel-j-h @springmeyer

@springmeyer
Copy link
Contributor

Can you say more why this is desirable/required? I created the link command specifically so that there would not be any versioned paths and you could safely specify the mason_packages/.link/ directory and have it work cross-platform. If you want platform-specific paths you can just use mason prefix paths. If there is a need for a hybrid that versions by platform but not by package version perhaps that could be a new command?

@kkaefer
Copy link
Member Author

kkaefer commented Jan 12, 2017

When using packages of multiple architectures simultaneously (e.g. various Android architectures, or iOS + macOS), all of those packages will be linked to the same path, but of course they have vastly different libraries. Using a single shared .link directory means that you can't e.g. build two Android versions side by side, or use iOS and macOS at the same time.

@springmeyer
Copy link
Contributor

per chat:

  • the only utility to the link command is when collapsing all paths
  • so, creating a linked directory of versioned paths is pointless
  • going to close this issue therefore, we'll rather consider keeping the mason link command as-is and deprecating in the future: Deprecate "mason link" command #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants