Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement this module as a pure JS wrapper around node-gdal #49

Closed
springmeyer opened this issue Nov 13, 2014 · 4 comments
Closed

Re-implement this module as a pure JS wrapper around node-gdal #49

springmeyer opened this issue Nov 13, 2014 · 4 comments

Comments

@springmeyer
Copy link

We should be able to drop the C++ code here, depend on node-gdal, and clean up the js code so that all tests still pass.

/cc @GretaCB @brandonreavis.

@brandonreavis
Copy link

This should be mostly done in this branch: https://github.com/naturalatlas/node-srs/tree/gdal-refactor.

The JS version of the C++ _parse method is here.

node-gdal was missing the SpatialReference.validate() / .fromESRI() methods, so I added those in. Once we publish the next version I'll start making sure all of the tests pass!

@springmeyer
Copy link
Author

fantastic! I'll take a look later this week. One comment now though: I prefer spaces over tabs :)

@springmeyer
Copy link
Author

Moving over at #59. Keeping the diff to a minimum for now to help review changes.

@springmeyer
Copy link
Author

Done in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants