Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency @turf/isolines has changed its API so version needs to be fixed #31

Open
mvl22 opened this issue Nov 15, 2018 · 0 comments
Open

Comments

@mvl22
Copy link

mvl22 commented Nov 15, 2018

The code calls isolines() at
https://github.com/mapbox/osrm-isochrone/blob/master/index.js#L20

However, that is using the pre-4.5.2 interface to @turf/isolines.

That interface was changed in:
Turfjs/turf@321d0df#diff-ba41233dbd590d55878b1d00a76de5b9
Turfjs/turf#781

Their example shows the difference:

- var isolined = turf.isolines(points, 'z', 15, breaks);
+ var isolines = turf.isolines(points, breaks, 'temperature');

So I think the version of @turf/isolines needs to be fixed as >=3.5.2 <4.5.2 at
https://github.com/mapbox/osrm-isochrone/blob/master/package.json#L32

or the calling code updated to the newer call format.

Subsequently the third parameter has been changed to an object, so is now set as the options.zProperty parameter:
https://github.com/Turfjs/turf/tree/master/packages/turf-isolines#isolines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant