Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svgo should be more than just dev-dependency? #72

Closed
andrewharvey opened this issue Jan 25, 2020 · 1 comment · Fixed by #73
Closed

svgo should be more than just dev-dependency? #72

andrewharvey opened this issue Jan 25, 2020 · 1 comment · Fixed by #73

Comments

@andrewharvey
Copy link

#68 introduced svgo into the library, however this was only made a dev-dependency. This causes issues when spritezero is a dependency of another library as it won't install svgo and will then crash when it can't find it.

It looks like either svgo will need to be a strict dependency or the methods that svgo requires pulled out of index.js?

@kkaefer
@kkaefer kkaefer mentioned this issue Jan 27, 2020
Merged
@kkaefer
Copy link
Member

kkaefer commented Jan 27, 2020

Yes, you're right. PR is in #73

@kkaefer kkaefer closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promote svgo to non-dev dependency mapbox/spritezero
2 participants
@kkaefer @andrewharvey