Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter_features output for MultiPolygons/MultiLineStrings/MultiPoints is not valid GeoJSON #45

Open
e-n-f opened this issue Feb 16, 2021 · 1 comment
Open

filter_features output for MultiPolygons/MultiLineStrings/MultiPoints is not valid GeoJSON #45

e-n-f opened this issue Feb 16, 2021 · 1 comment

Comments

@e-n-f
Copy link

e-n-f commented Feb 16, 2021

filter_features decomposes MultiPolygons, MultiLineStrings, and MultiPoints into sub-features, but its output is not valid GeoJSON because these sub-features do not have a properties.
@dnomadb dnomadb mentioned this issue Feb 16, 2021
Open
@dnomadb
Copy link
Contributor

dnomadb commented Feb 16, 2021 •
edited
Loading

@ericfischer in hindsight, I think the best way to handle this would have been to always deal with the geometry object only, as this is only what is needed internally for supermercado. But, I don't want to break any functionality so I added test + a PR to simply pass through whatever is provided to said function (as it currently works for non-Multi* geometry types): #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-n-f @dnomadb