Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider solidifying tilesource API as a prototype #153

Open
tcql opened this issue Nov 12, 2015 · 2 comments
Open

consider solidifying tilesource API as a prototype #153

tcql opened this issue Nov 12, 2015 · 2 comments

Comments

@tcql
Copy link
Contributor

tcql commented Nov 12, 2015

During some discussion in gis-devs slack, it was pointed out that not all tilelive Tilesource implementations have the full api (tilelive-mapnik implements getGrid, while tilelive-bridge does not. And API.md suggests that getGrid is standard for Tilesources).

It might be nice if we have a Tilesource function that stubs all expected methods on it's prototype, and rework existing Tilesources to inherit the prototype. This ensures that even if a source doesn't fully implement the Tilesource API, the stubs at least exist. I think this also solidifies expectations around what should be implemented by a custom Tilesource, and how to start building a custom Tilesource.

@tmcw
Copy link
Contributor

tmcw commented Nov 12, 2015

(tilelive-mapnik implements getGrid, while tilelive-bridge does not. And API.md suggests that getGrid is standard for Tilesources).

I'd suggest that getGrid should not be part of the minimal tilelive API.

@yhahn
Copy link
Member

yhahn commented Nov 16, 2015

Hmm, I understand the pains here. Some context:

  • Not a huge fan of JS inheritance as a way of enforcing a spec,
  • Tilelive "spec" is currently in somewhat of a discovery phase as the tile ecosystem has changed considerably since its inception. Per @tmcw's comment utfgrid's are a deprecated technology (replaced by vector tiles) and we've also seen more interfaces that require getTile inputs beyond z/x/y (retina? language support? other options?)

My take is to observe how our current generation of modules continue to adapt to the image => vector transition (with how raster tiles make it through a big question) and then to adjust our spec accordingly before looking to codify the spec further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants