Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin tag and align tests #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

boldtrn
Copy link

@boldtrn boldtrn commented May 17, 2018

Fixes #143.

This PR adds a origin tag in the properties for every feature generated from GPX. Let me know what you think and if I should change anything.

@boldtrn
Copy link
Author

boldtrn commented May 17, 2018

BTW: There seems to be a failure with 5 kml tests that already failed in the current master. I had hoped this was due to my local setup, but it seems to fail on Travis as well. I am not really sure why this happens and I think this should not be related to this PR.

@joukewitteveen
Copy link
Contributor

I think the CI failures are caused by 9c5c3cc. In fact, #123 shows that the author is aware of the fact that the test data should be updated. Unfortunately, this has not happened.

@joukewitteveen
Copy link
Contributor

I think it makes sense to rename this from origin to something like gpxType. That way, it is more intuitive for togpx to support the same tag so that a roundtrip togeojson-togpx retains as much of the original as possible. For the togpx use-case, the name origin would be a bit weird.

The togpx part of this change would then be an alternative to tyrasd/togpx#11.

@boldtrn
Copy link
Author

boldtrn commented May 15, 2019

Sure, we could change the name. So far this PR did not receive much attention, so I am not sure if it's worth the effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From GPX store the origin Track|Route|Waypoint
2 participants