Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve setFilter documentation #295

Closed
oscarlorentzon opened this issue Sep 12, 2019 · 1 comment
Closed

Improve setFilter documentation #295

oscarlorentzon opened this issue Sep 12, 2019 · 1 comment
Assignees
@oscarlorentzon
Labels
affects-docs
Milestone
2.18.1

Comments

@oscarlorentzon
Copy link
Member

oscarlorentzon commented Sep 12, 2019 •
edited
Loading

The Viewer.setFilter documentation could be improved with a list of commonly used property names (linked from the Node class) to make it clearer.

Also, the setFilter example could have commented out lines where the filters for those properties are set.

Additionally, a specific setFilter example for filtering on organization could be added because it is a common use case.
@oscarlorentzon oscarlorentzon self-assigned this Sep 12, 2019
@oscarlorentzon oscarlorentzon changed the title Improv setFilter documentation Improve setFilter documentation Sep 12, 2019
@oscarlorentzon oscarlorentzon added this to the 2.18.1 milestone Sep 19, 2019
@oscarlorentzon
Copy link
Member Author

Fixed in d1c7dd8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarlorentzon oscarlorentzon

Labels
affects-docs
Projects
None yet
Milestone
2.18.1
Development

No branches or pull requests
1 participant
@oscarlorentzon