You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The docs website https://github.com/maplibre/maplibre-gl-js is written in JavaScript. It used to build the docs of the style spec by directly reading the source files in src/style-spec/**/*.js. As these file were migrated to TypeScript in #209, I changed the docs repo to use the rollup output from rollup/build/tsc/src/style-spec/**/*.js to build the style spec docs.
The two step build process was simplified to a single step in #961 I think. Now we don't have the intermediate .js files of the style spec anymore which we need because the docs repo uses JavaScript and not TypeScript.
Should we re-introduce the functionality of the old npm run build-tsc script which generated the intermediate .js files?
The text was updated successfully, but these errors were encountered:
I would consider addind this to the docs repo so that it will contain the logic it needs to build the docs.
Since it uses submodule it has the typescript code and can generate what it needs from it I suppose.
That's my 2 cents at least.
The docs website https://github.com/maplibre/maplibre-gl-js is written in JavaScript. It used to build the docs of the style spec by directly reading the source files in
src/style-spec/**/*.js
. As these file were migrated to TypeScript in #209, I changed the docs repo to use the rollup output fromrollup/build/tsc/src/style-spec/**/*.js
to build the style spec docs.The two step build process was simplified to a single step in #961 I think. Now we don't have the intermediate
.js
files of the style spec anymore which we need because the docs repo uses JavaScript and not TypeScript.Should we re-introduce the functionality of the old
npm run build-tsc
script which generated the intermediate.js
files?The text was updated successfully, but these errors were encountered: