Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs website requires .js style-spec files #1015

Closed
wipfli opened this issue Feb 20, 2022 · 1 comment
Closed

Docs website requires .js style-spec files #1015

wipfli opened this issue Feb 20, 2022 · 1 comment

Comments

@wipfli
Copy link
Contributor

wipfli commented Feb 20, 2022

The docs website https://github.com/maplibre/maplibre-gl-js is written in JavaScript. It used to build the docs of the style spec by directly reading the source files in src/style-spec/**/*.js. As these file were migrated to TypeScript in #209, I changed the docs repo to use the rollup output from rollup/build/tsc/src/style-spec/**/*.js to build the style spec docs.

The two step build process was simplified to a single step in #961 I think. Now we don't have the intermediate .js files of the style spec anymore which we need because the docs repo uses JavaScript and not TypeScript.

Should we re-introduce the functionality of the old npm run build-tsc script which generated the intermediate .js files?

@HarelM
Copy link
Collaborator

HarelM commented Feb 20, 2022

I would consider addind this to the docs repo so that it will contain the logic it needs to build the docs.
Since it uses submodule it has the typescript code and can generate what it needs from it I suppose.
That's my 2 cents at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants